GitLab

Add test & workaround wrong templating of hostvars

See merge request !348

Workaround this issue https://github.com/ansible/ansible/pull/64282
which has been fixed with Ansible 2.9.1

Completes 2544db60

Allow to execute OpenStack integration tests only

See merge request !345

Handle Jinja templates in variables

See merge request !336

Use ansible instead of ansible-inventory in order to handle template
within variables. Move ansible-playbook from Ansible class to Playbook
class.

using:

    tests/run-tests.sh tox -e py3 -- -m openstack_integration tests/

Tested with:

    $ time PYTEST_ADDOPTS='-m "not openstack_integration" --collect-only' tests/run-tests.sh
    [...]
    collected 100 items / 23 deselected / 77 selected
    [...]
    py3: commands succeeded
    flake8: commands succeeded
    docs: commands succeeded
    congratulations :)

    real    1m33.293s
    user    0m0.967s
    sys 0m0.384s

Removed debug from enough / Django config

See merge request !343

remove Ansible.set_inventories method

See merge request !342

rationale: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments

This method was used only by the unit tests.

Avoid timeout from SSH client: don't restart SSH service

See merge request !341

- use reload instead of restart
- reload service as soon as possible
- reload only when the default SSH port isn't used

Workaround 'Connection timed out' from SSH client. These timeouts occur
while SSH service is restarted:

    # journalctl -o short-precise -u sshd
    18:22:57.447216 copy-to-host systemd[1]: Started OpenBSD Secure Shell server.
    18:22:57.878128 copy-to-host sshd[601]: Did not receive identification string from 82.123.240.182
    18:23:20.370278 copy-to-host sshd[580]: Received signal 15; terminating.
    18:23:20.371926 copy-to-host systemd[1]: Stopping OpenBSD Secure Shell server...
    18:23:20.373162 copy-to-host systemd[1]: Stopped OpenBSD Secure Shell server.
    18:23:20.375161 copy-to-host systemd[1]: Starting OpenBSD Secure Shell server...
    18:23:20.392807 copy-to-host sshd[885]: Server listening on :: port 22.
    18:23:20.393059 copy-to-host systemd[1]: Started OpenBSD Secure Shell server.

    # journalctl -o short-precise -u cloud-final.service
    18:22:58.139066 copy-to-host systemd[1]: Starting Execute cloud user/final scripts...
    18:22:58.724808 copy-to-host cloud-init[606]: Provision began: 2020-11-09 18:22:58.724631
    [...]
    18:23:20.502234 copy-to-host cloud-init[606]: Cloud-init v. 20.2 running 'modules:final' at Mon, 09 Nov 2020 18:22:58 +0000. Up 14.85 seconds.
    18:23:20.502234 copy-to-host cloud-init[606]: Cloud-init v. 20.2 finished at Mon, 09 Nov 2020 18:23:20 +0000. Datasource DataSourceOpenStackLocal [net,ver=2].  Up 36.
    Nov 09 18:23:20.544560 copy-to-host systemd[1]: Started Execute cloud user/final scripts.

'log-cli-level' pytest switch enable log output too

See merge request !340

It doesn't only control the test log level.

test_clone_clobber don't use OpenStack API

See merge request !339

Remove extraneous line

See merge request !338

Fix "'dict' object has no attribute 'strip'" exception which has been
introduced by 252ce4e0.

Destroy ressources created by test_openstack_create_or_update

See merge request !337

Call o.destroy_everything(None) instead of using openstack_name fixture.

'openstack_name' fixture can not be used to destroy the created
ressources. Indeed the prefix can not be reused (there is no way to
use the prefix with ServiceOpenStack.create_or_update).

This issue was encountered while using the following command:

    $ tests/run-tests.sh tox -e py3 -- -k "test_openstack_create_or_update or test_clone_and_destroy" tests/enough/
    [...]
    tests/enough/common/test_common_service.py::test_openstack_create_or_update PASSED
    tests/enough/common/test_init.py::test_clone_and_destroy FAILED

    =================================== FAILURES ===================================
    ____________________________ test_clone_and_destroy ____________________________

    @pytest.mark.skipif('SKIP_OPENSTACK_INTEGRATION_TESTS' in os.environ,
                        reason='skip integration test')
    def test_clone_and_destroy(tmpdir):
	[...]
        original = Enough(original_config_dir, settings.SHARE_DIR,
                          domain=original_domain,
                          driver='openstack')
    >   assert original.openstack.o.server.list().strip() == ''
    E   AssertionError: assert '+-----------...---+--------+' == ''
    E     - +-----------+--------+---------------------+-----------+--------+
    E     - | Name      | Status | Networks            | Image     | Flavor |
    E     - +-----------+--------+---------------------+-----------+--------+
    E     - | bind-host | ACTIVE | Ext-Net=51.68.95.206| Debian 10 | s1-2   |
    E     - +-----------+--------+---------------------+-----------+--------+

    tests/enough/common/test_init.py:38: AssertionError

ansible_utils: use only one bake method

See merge request main/infrastructure!332

use unchanged 'json' format instead of 'value'

See merge request main/infrastructure!335

Fix this issue:

    $ tests/run-tests.sh tox -e py3 -- -k test_create_missings tests/enough/common/test_init.py
    [...]
    Traceback (most recent call last):
      File "/srv/share/src/ansible/enough.community/infrastructure.git/tests/enough/common/test_init.py", line 290, in test_create_missings
	assert bind_internal_ip == internal_dns
    AssertionError: assert '10.30.20.120' == "['10.30.20.120']"
      - 10.30.20.120
      + ['10.30.20.120']
      ? ++            ++

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/srv/share/src/ansible/enough.community/infrastructure.git/enough/common/retry.py", line 19, in f_retry
	return f(*args, **kwargs)
      File "/srv/share/src/ansible/enough.community/infrastructure.git/enough/common/openstack.py", line 399, in destroy_everything
	raise OpenStackLeftovers('scheduled removal of ' + ' '.join(leftovers))
    enough.common.openstack.OpenStackLeftovers: scheduled removal of stack(bind-host) network(internal)
    openstack.py               341 INFO     destroy_everything acting
    openstack.py                34 INFO     []

Destroy volumes and snapshots using ID instead of Name

See merge request main/infrastructure!334